D7649: match: make sure `root` argument is always an absolute path (API)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Dec 20 09:53:11 EST 2019


martinvonz added inline comments.
martinvonz marked an inline comment as done.

INLINE COMMENTS

> pulkit wrote in match.py:186
> Hm, does this has to be always `/repo` or `/foo` is also a valid parameter here?

I've changed this one back.

> pulkit wrote in test-match.py:69
> This and below ones can be `/x` too right?

I've left this one as `/repo` because I think it's clearer that it's a repo path that way.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7649/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7649

To: martinvonz, #hg-reviewers, mharbison72
Cc: pulkit, mharbison72, mercurial-devel


More information about the Mercurial-devel mailing list