D7574: hg-core: add utils::path to project

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Dec 23 13:14:46 EST 2019


indygreg added inline comments.

INLINE COMMENTS

> Alphare wrote in Cargo.toml:12
> Should we adopt this crate for error handling?
> 
> I feel like our current solution - although it might need a refactor - is good at forcing the programmer to provide context with finer-grained errors that what you are required to do with `anyhow`.  I actually like `anyhow` better than more involved crates, but we will need to have a good "error hygiene" if you will.
> 
> This seems like a better place to discuss this than the previous patch.

I actually wasn't aware of `anyhow` before writing this patch. And I have to say that I really like `anyhow` because it is simpler than other crates in this space while offering much of the same functionality.

I think it is inevitable that we'll want to use a crate like `anyhow` for more advanced error handling. If nothing else, it can help cut down on boilerplate code around error handling.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7574/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7574

To: indygreg, #hg-reviewers
Cc: Alphare, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list