D7705: phases: make the working directory consistently a draft
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Fri Dec 27 11:01:04 EST 2019
marmoute added a comment.
In D7705#113667 <https://phab.mercurial-scm.org/D7705#113667>, @rdamazio wrote:
> In D7705#113383 <https://phab.mercurial-scm.org/D7705#113383>, @marmoute wrote:
>> The working copy is not necessarly draft phase. For example, it will be secret is the working copy parent is secret. One can also control it using the `phases.new-commit` config.
>> The `mercurial.phases.newcommitphase(ui)` function can help you there.
> About `newcommitphase` - that only accounts for the config option, and it seems that the working directory doesn't change phase based on that in other parts of the code (e.g. in `commitablectx`), so I kept that consistent here.
`commitablectx` code seems wrong here. I am sending a patch.
CHANGES SINCE LAST ACTION
To: rdamazio, #hg-reviewers, marmoute
Cc: marmoute, mercurial-devel
More information about the Mercurial-devel