D7716: rust-discovery: partial switch to typestate pattern

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Dec 27 12:42:17 EST 2019


This revision now requires changes to proceed.
martinvonz added a comment.
martinvonz requested changes to this revision.


  Did you consider encoding the state in a type parameter to `PartialDiscovery`? I think that would make the call sites simpler. See the last variation on http://cliffle.com/blog/rust-typestate/ for what I mean.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7716/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7716

To: gracinet, #hg-reviewers, martinvonz
Cc: martinvonz, Alphare, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list