D7754: hgweb: delete local variable instead of setting it to `None`

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Dec 27 20:29:10 EST 2019


mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The previous code was flagged by PyCharm as an unused variable assignment.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7754

AFFECTED FILES
  mercurial/hgweb/hgwebdir_mod.py

CHANGE DETAILS

diff --git a/mercurial/hgweb/hgwebdir_mod.py b/mercurial/hgweb/hgwebdir_mod.py
--- a/mercurial/hgweb/hgwebdir_mod.py
+++ b/mercurial/hgweb/hgwebdir_mod.py
@@ -486,7 +486,7 @@
             )
             return res.sendresponse()
         finally:
-            tmpl = None
+            del tmpl
 
     def makeindex(self, req, res, tmpl, subdir=b""):
         self.refresh()



To: mharbison72, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list