D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839)

[durin42 (Augie Fackler)]

durin42 added a comment.


  In https://phab.mercurial-scm.org/D5744#84960, @spectral wrote:
  
  > In https://phab.mercurial-scm.org/D5744#84938, @yuja wrote:
  >
  > > > I did not add this to `revert --interactive`, since that does not currently have any way of getting args specified on the commandline that affect the whitespace settings (so I'm keeping `revert --interactive` *ignoring* the user's diff settings).
  > >
  > > Well, `hg revert --interactive` does respect the user's diff settings. I don't
  > >  know why, but https://phab.mercurial-scm.org/rHGf37a69ec3f4717fdb4f00699ca06c225f106696c explicitly added `whitespace=True`.
  >
  >
  > If I had to guess, I think that was just a copy/paste from `commit --interactive` without realizing the consequences;
  
  
  That would be my guess too. I'm inclined to treat that as a bug, since the whitespace elision will at best produce confusing results.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5744

To: spectral, #hg-reviewers
Cc: durin42, yuja, navaneeth.suresh, mercurial-devel