D5794: py3: pass str into grp.getgrnam
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Feb 1 21:06:24 EST 2019
indygreg added a comment.
In https://phab.mercurial-scm.org/D5794#85031, @yuja wrote:
> Perhaps, it should be `fsdecode()` since they appear to abuse
> `PyUnicode_EncodeFSDefault()` to get back bytes.
>
> And we'll probably need to `fsencode()` gr_mem back to bytes as well.
Ugh, Python. And the raw system call accepts a `char *`. So this whole "pretend to be Unicode" is just plain silly.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5794
To: pulkit, #hg-reviewers
Cc: indygreg, yuja, mercurial-devel
More information about the Mercurial-devel
mailing list