D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839)

Yuya Nishihara yuya at tcha.org
Fri Feb 1 23:02:56 EST 2019


> The ultimate reason I abandoned that and went with the "only respect commandline options, not config, and don't do this for `revert --interactive`" patch series was because I had to include a note that said something like "if a user *does* set `commands.commit.interactive.{ignorews,ignoreblanklines,...}`, this will still trigger issue5839; it is unlikely that any user will want to set these options, though."
>   
>   It's up to you, though. I worry I'm too ingrained in the internal-software development culture where we control what versions people have and can provide quick assistance when users have questions or encounter problems. I might not be properly considering the issues people might run into outside of an enterprise situation.

I agree with that we would never set the `commands.commit.interactive.{...}`
in hgrc, but the feature itself is useful if you have to work on unclean
codebase unlike in Google. For example, I sometimes need to commit changes
ignoring unrelated whitespace cleanups made by editor or code formatter,
because I can't control the development workflow.

That's why I thought there would be users relying on the current behavior.


More information about the Mercurial-devel mailing list