D5745: status: extract helper for producing relative or absolute path for UI

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sat Feb 2 00:14:42 EST 2019

martinvonz added a comment.

  In https://phab.mercurial-scm.org/D5745#85049, @yuja wrote:
  > >> +    relative = pats or ui.configbool('commands', 'status.relative'):
  > >  > +    uipathfn = scmutil.getuipathfn(repo, relative)
  > > 
  > > Not sure if it's worth fixing the syntax error here before it goes public.  I only noticed because I was bisecting a test failure.  The next patch drops the trailing `:`.
  > Fixed, thanks.
  Thanks to both of you. I'll try to be more careful in the future.

  rHG Mercurial


To: martinvonz, #hg-reviewers, pulkit
Cc: yuja, mharbison72, mercurial-devel

More information about the Mercurial-devel mailing list