D5803: revert: added prompt before undeleting a file in -i(issue6008)

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Feb 2 21:36:28 EST 2019


yuja added a comment.


  > +        if interactive:
  >  +            choice = repo.ui.promptchoice(
  >  +                _("Undelete file %s (Yn)?$$ &Yes $$ &No") % f)
  
  Nit: "undelete" (no capital letter) per Mercurial's convention.
  
  And I don't think "undelete" is good for user-facing messages. Perhaps, it
  can be phrased as "add back removed file %s (Yn)?".

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5803

To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list