[PATCH 1 of 2] extdiff: support tools that can be run simultaneously

Yuya Nishihara yuya at tcha.org
Sun Feb 3 07:19:13 EST 2019


On Sat, 02 Feb 2019 22:43:59 -0800, Ludovic Chabant wrote:
> One thing I'm not quite sure about this change is how to handle the new "gui" config flag.
> 
> I wanted to use (abuse?) the difference between False and None in order to figure out if we found the flag in a section or not (and fall back to another section if not). However, passing None as the default to ui.config yields warnings about mismatched default values, which is why I ended up registering the flag with None as its default... that might be wrong,

That seems fine.

> but I don't know if there's a better way, short of doing some clunky juggling with ui.hasconfig ?

Using hasconfig() is also fine.

> (I also just realized I should use ui.configbool instead of ui.config)

Yep.

> Unrelated: git email reviews allow editing a patch before sending it via email, so you can add some review-only text in it (look for "timely commentary" on this page: https://git-scm.com/docs/git-format-patch#_discussion). Is there some similar convention for mercurial patch emails? Or are we supposed to just reply to the patch email right away like I'm doing right now?

I prefer including that in commit message. You could edit a mbox file to insert
commentary before the "# HG changeset patch" header, but it seems unnecessarily
complicated.


More information about the Mercurial-devel mailing list