D5853: revert: migrate to scmutil.backuppath()

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Feb 5 13:22:31 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> cmdutil.py:3017-3018
> +                            bakname = scmutil.backuppath(ui, repo, abs)
>                              ui.note(_('saving current version of %s as %s\n') %
>                                      (rel, bakname))
>                              if not opts.get('dry_run'):

Sorry, there is a regression here: if you're in a subdirectory, this used to say "saving current version of foo as foo.orig", but now it will say "saving current version of foo as dir/foo.orig". So please don't queue this yet. I'll need to insert some patches earlier in the series.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5853

To: martinvonz, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list