D5896: diff: make --stat respect ui.relative-paths

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sun Feb 10 01:07:32 EST 2019


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D5896#86559, @yuja wrote:
  
  > >   It would have been easy to make all diffs respect ui.relative-paths,
  > >   but we don't want that since it makes the diff invalid. Perhaps it
  > >   makes sense to do that with --noprefix since the point of that is to
  > >   make paths that are easy to copy&paste, and the diff is already
  > >   invalid anyway. But this patch just makes the --stat version respect
  > >   the config option. The --stat view is not even close to a valid diff,
  > >   so I think it makes sense to show the paths in more human-friendly
  > >   form.
  >
  > Seems fine, but I'm not sure about the Windows behavior:
  >
  > - Do we want to see backslash paths on Windows?
  
  
  I would assume that we want that.
  
  > - Backslash paths are parsed correctly?
  
  Good question! Some simple testing I just did suggests that it does work.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5896

To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list