D5945: rust: itering less on MissingAncestors.bases for max()

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Tue Feb 12 09:58:39 EST 2019


kevincox accepted this revision.
kevincox added inline comments.

INLINE COMMENTS

> ancestors.rs:41
>      bases: HashSet<Revision>,
> +    max_base: Option<Revision>,
>  }

Does it make sense to just default this to -1 and remove the option?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5945

To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list