D5972: exchange: raise error.Abort instead of ValueError
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Feb 15 14:55:59 EST 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3b0ba4575c8c: exchange: raise error.Abort instead of ValueError (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5972?vs=14105&id=14107
REVISION DETAIL
https://phab.mercurial-scm.org/D5972
AFFECTED FILES
mercurial/exchange.py
tests/test-lfs-serve.t
CHANGE DETAILS
diff --git a/tests/test-lfs-serve.t b/tests/test-lfs-serve.t
--- a/tests/test-lfs-serve.t
+++ b/tests/test-lfs-serve.t
@@ -56,11 +56,10 @@
> EOF
Skip the experimental.changegroup3=True config. Failure to agree on this comes
-first, and causes a "ValueError: no common changegroup version" or "abort:
-HTTP Error 500: Internal Server Error", if the extension is only loaded on one
-side. If that *is* enabled, the subsequent failure is "abort: missing processor
-for flag '0x2000'!" if the extension is only loaded on one side (possibly also
-masked by the Internal Server Error message).
+first, and causes an "abort: no common changegroup version" if the extension is
+only loaded on one side. If that *is* enabled, the subsequent failure is "abort:
+missing processor for flag '0x2000'!" if the extension is only loaded on one side
+(possibly also masked by the Internal Server Error message).
$ cat >> $HGRCPATH <<EOF
> [extensions]
> debugprocessors = $TESTTMP/debugprocessors.py
@@ -320,7 +319,8 @@
$ hg -R $TESTTMP/client4_pull pull http://localhost:$HGPORT
pulling from http://localhost:$HGPORT/
requesting all changes
- abort: HTTP Error 500: Internal Server Error
+ remote: abort: no common changegroup version
+ abort: pull failed on remote
[255]
$ grep 'lfs' $TESTTMP/client4_pull/.hg/requires $SERVER_REQUIRES
$TESTTMP/server/.hg/requires:lfs
@@ -664,10 +664,4 @@
$ "$PYTHON" $TESTDIR/killdaemons.py $DAEMON_PIDS
-#if lfsremote-on
- $ cat $TESTTMP/errors.log | grep '^[A-Z]'
- Traceback (most recent call last):
- ValueError: no common changegroup version
-#else
$ cat $TESTTMP/errors.log
-#endif
diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -920,7 +920,7 @@
if v in changegroup.supportedoutgoingversions(
pushop.repo)]
if not cgversions:
- raise ValueError(_('no common changegroup version'))
+ raise error.Abort(_('no common changegroup version'))
version = max(cgversions)
cgstream = changegroup.makestream(pushop.repo, pushop.outgoing, version,
'push')
@@ -2184,7 +2184,7 @@
cgversions = [v for v in cgversions
if v in changegroup.supportedoutgoingversions(repo)]
if not cgversions:
- raise ValueError(_('no common changegroup version'))
+ raise error.Abort(_('no common changegroup version'))
version = max(cgversions)
outgoing = _computeoutgoing(repo, heads, common)
@@ -2228,7 +2228,7 @@
if not kwargs.get(r'bookmarks', False):
return
if 'bookmarks' not in b2caps:
- raise ValueError(_('no common bookmarks exchange method'))
+ raise error.Abort(_('no common bookmarks exchange method'))
books = bookmod.listbinbookmarks(repo)
data = bookmod.binaryencode(books)
if data:
@@ -2263,7 +2263,7 @@
"""add phase heads part to the requested bundle"""
if kwargs.get(r'phases', False):
if not 'heads' in b2caps.get('phases'):
- raise ValueError(_('no common phases exchange method'))
+ raise error.Abort(_('no common phases exchange method'))
if heads is None:
heads = repo.heads()
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list