D5969: uncommit: inform user if the commit is empty after uncommit
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Feb 15 15:20:22 EST 2019
martinvonz added inline comments.
> pulkit wrote in uncommit.py:87
> how about something like this `(preserving the empty commit)`. The reason is that we need to tell that the empty commit is preserved more than the fact the commit is empty.
> note the `(`, it makes it look like a help text.
I added a `note: ` in front instead. I think we usually use parentheses for hints.
I also changed s/preserving/keeping/ to match the term we use in the `--keep` flag (and the upcoming config option).
I kind of like the `all files uncommitted` part since it explains what empty commit we're talking about. Should I add it back?
To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel