D5969: uncommit: inform user if the commit is empty after uncommit
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Fri Feb 15 15:27:31 EST 2019
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in uncommit.py:87
> I added a `note: ` in front instead. I think we usually use parentheses for hints.
>
> I also changed s/preserving/keeping/ to match the term we use in the `--keep` flag (and the upcoming config option).
>
> I kind of like the `all files uncommitted` part since it explains what empty commit we're talking about. Should I add it back?
> I kind of like the all files uncommitted part since it explains what empty commit we're talking about. Should I add it back?
sure!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5969
To: martinvonz, #hg-reviewers
Cc: pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list