[PATCH 10 of 10] transaction: include txnname in the hookargs dictionary

Boris FELD boris.feld at octobus.net
Mon Feb 18 04:16:29 EST 2019


On 09/02/2019 23:34, Pulkit Goyal wrote:
>
>
> On Sun, Feb 10, 2019 at 3:54 AM Boris Feld <boris.feld at octobus.net
> <mailto:boris.feld at octobus.net>> wrote:
>
>     # HG changeset patch
>     # User Boris Feld <boris.feld at octobus.net
>     <mailto:boris.feld at octobus.net>>
>     # Date 1549749690 -3600
>     #      Sat Feb 09 23:01:30 2019 +0100
>     # Node ID f4936120d74a81199068bed14a04ac65f24f6109
>     # Parent  62d13ee8373ad4a7c97192680a4781fe5818a1df
>     # EXP-Topic hook.txname
>     # Available At https://bitbucket.org/octobus/mercurial-devel/
>     #              hg pull
>     https://bitbucket.org/octobus/mercurial-devel/ -r f4936120d74a
>     transaction: include txnname in the hookargs dictionary
>
>     There is no reason to not include the txnname alongside the txnid
>     in all case.
>     So let's do that. If the transaction name is useful to internal
>     code, it can
>     be useful for hooks.
>
>
> What are the cases when we have transaction name and source different?

I don't remember anything specific about the rationale for this patch.
It has been laying around for a long while (first version date back from
May 2015). At that point, I think the point is mostly to make the shell
hook consistent with the python one. (Because the Python one take this
argument already).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190218/86d2f2c1/attachment.html>


More information about the Mercurial-devel mailing list