D5966: test: stabilize test-run-tests.t output

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Mon Feb 18 04:29:43 EST 2019


lothiraldan added inline comments.

INLINE COMMENTS

> durin42 wrote in test-run-tests.t:1177
> Maybe we could make it 3,5 so it's be more permissive?

Yes we could.

I think the regex was previously `{4,5}` for two reasons:

- We expected the duration to be less than 10 seconds.

- The precision of the number was 3 digits or 4 digits after the dot depending if we used json or simplejson for dumping the data.

Right now, it seems that `run-tests.py` itself is limitation the precision of the digits.

So we can either drop the {3,4} as we should have a stable number of digits after the dot, and anyone changing the precision of times in `run-tests.py` will have a diff in this test.

Or we make it more permissive so we don't need to bother about updating it later.

I don't have a strong opinion about either, what do you think we should do?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5966

To: lothiraldan, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list