D5981: tests: drop a few unnecessary "(glob)"

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Feb 19 00:53:52 EST 2019


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D5981#87341, @mharbison72 wrote:
  
  > The tests run clean with this.
  >
  > But I'm a bit confused.  The test harness has been doing '\' -> '/' conversion without (glob) now for a little over a year, and it complains if there's a trailing (glob) and no '\' -> '/' conversion.  That's not been happening here, and made me suspicious.  These globs predate that functionality slightly, so I'm not sure the meaning of the referenced commit (which seems to say nothing will change because ui.slash is set).
  
  
  You're right, and even if I go back to https://phab.mercurial-scm.org/rHGbdcaf612e75a08f20257076845510353a448b57d (where you added these globs), it seems like it should have been converted to slashes already there (because the test runner set ui.slash back then, too, and the code seemed to respect that). Do you have time to go back and see if the globbing was never needed?
  
  Maybe the "no complaining from test harness" is because these lines contain a "?", which is a glob character, so maybe it doesn't warn then?
  
  > To be clear, these paths are still being printed with '\', and the test harness is accommodating that.  But I'm not sure if that's what you intended.
  
  Yes, I hope that my recent changes has made it so more commands, not fewer, print paths in the native form.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5981

To: martinvonz, #hg-reviewers, mharbison72
Cc: mercurial-devel


More information about the Mercurial-devel mailing list