D5514: test: change test's diff generation to use mdiff for nicer output

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Feb 19 10:08:58 EST 2019

durin42 added a comment.

  Even with my in-flight fixes, I can't get this to use the non-unified_diff codepath. Can you test again?
  https://bitbucket.org/snippets/durin42/nejj94 has my in-flight fixes, but you may find it challenging to apply (the test output in the commit message confuses the patch parser). Hopefully that helps...


> run-tests.py:80
> +    _diff = mdiff.new_diff
> +except except (ImportError, AttributeError):
> +    print("Falling back to unified_diff")

In the future please *run tests* before requesting another round of review: this is a trivial syntax error and proves you didn't try running tests.

  rHG Mercurial


To: sangeet259, #hg-reviewers, durin42
Cc: pulkit, durin42, mercurial-devel

More information about the Mercurial-devel mailing list