D5514: test: change test's diff generation to use mdiff for nicer output
Sangeet Kumar Mishra
mail2sangeetmishra at gmail.com
Tue Feb 19 10:38:14 EST 2019
Apologies, I didn't run the tests after the latest addition. 😔
On Tue, Feb 19, 2019, 20:39 durin42 (Augie Fackler) <
phabricator at mercurial-scm.org wrote:
> durin42 added a comment.
>
>
> Even with my in-flight fixes, I can't get this to use the
> non-unified_diff codepath. Can you test again?
>
> https://bitbucket.org/snippets/durin42/nejj94 has my in-flight fixes,
> but you may find it challenging to apply (the test output in the commit
> message confuses the patch parser). Hopefully that helps...
>
> INLINE COMMENTS
>
> > run-tests.py:80
> > + _diff = mdiff.new_diff
> > +except except (ImportError, AttributeError):
> > + print("Falling back to unified_diff")
>
> In the future please *run tests* before requesting another round of
> review: this is a trivial syntax error and proves you didn't try running
> tests.
>
> REPOSITORY
> rHG Mercurial
>
> REVISION DETAIL
> https://phab.mercurial-scm.org/D5514
>
> To: sangeet259, #hg-reviewers, durin42
> Cc: pulkit, durin42, mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190219/b282c4d3/attachment.html>
More information about the Mercurial-devel
mailing list