D5961: copies: add test that makes both the merging csets dirty and run w/o error

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Feb 25 12:27:07 EST 2019

martinvonz added inline comments.


> test-copytrace-heuristics.t:724-728
> +  $ cat >> $HGRCPATH << EOF
> +  > [experimental]
> +  > evolution.createmarkers=True
> +  > evolution.allowunstable=True
> +  > EOF

Since this does not seem to set `experimental.copytrace = heuristics` (right?), this is probably not the right file for the test case. I recently added `test-copies.t`, which may be a better place for this. That file doesn't yet have any tests for `mergecopies()` (only for `pathcopies()`), but I was probably going to add that later anyway. Depending on how many tests I would add, I might have put all `mergecopies()` tests in a separate file, but since there isn't much at this point (only these few that you're adding), it probably makes sense for them to live in `test-copies.t`.

  rHG Mercurial


To: khanchi97, #hg-reviewers
Cc: martinvonz, mercurial-devel

More information about the Mercurial-devel mailing list