D5299: phabricator: fallback reading arcanist config files
philpep (Philippe Pepiot)
phabricator at mercurial-scm.org
Wed Feb 27 05:49:48 EST 2019
philpep marked 3 inline comments as done.
philpep added inline comments.
> mharbison72 wrote in phabricator.py:187
> s/.encoding/.environ/ ?
Woops... Thanks for catching this!
> mharbison72 wrote in phabricator.py:200
> Should this be using vfs to open, instead of raw open? Using the vfs layer allows the class that provides posix-like functionality on Windows to be used.
> mharbison72 wrote in phabricator.py:290
> It might be clearer to return None, since the function is to fetch the repoid.
Indeed, I fixed this.
To: philpep, #hg-reviewers
Cc: mharbison72, mercurial-devel
More information about the Mercurial-devel