D5441: rust-cpython: binding for LazyAncestors
kevincox (Kevin Cox)
phabricator at mercurial-scm.org
Thu Jan 3 15:24:45 UTC 2019
kevincox added a comment.
In https://phab.mercurial-scm.org/D5441#81222, @yuja wrote:
> Anyway, I just thought using CamelCase in Rust would be slightly nicer and
> simpler. If that makes things complicated, I'll drop my idea and stick to
> anything that is simpler.
I think using the Rust naming convention in Rust and the Python convention in Python is probably the best. It does make it slightly harder to grep the codebase for these things but since you would find the explicit registration linking the two names I don't think it is a major issue.
> I believe implementing Into is not readily possible with the rust-cpython way of creating Python exceptions : we can't do it without the py marker
Ah right, I missed this. In this case I think the manual conversion is fine.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5441
To: gracinet, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list