D5483: amend:added config option to update time to current in hg amend(issue5828)

[pulkit (Pulkit Goyal)]

pulkit added a comment.


  Nice! I left an inline comment.
  
  How are you sending patches? I am unable to see the whole file in phabricator. If you are not using `hg phabsend`, please use that next time.
  
  For how to use `hg phabsend`: https://www.mercurial-scm.org/wiki/Phabricator

INLINE COMMENTS

> cmdutil.py:2559
>          if ((not changes)
>              and newdesc == old.description()

How about if we leave this `if` statement as it is and do following after the if statement:

- check whether --date is passed or not
- if not, change the date to current date

nit:  Return value of ui.configbool() is a boolean and you don't need to compare that tp True.

REVISION DETAIL
  https://phab.mercurial-scm.org/D5483

To: taapas1128, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel