D5491: amend:added config option to update time to current in hg amend(issue5828)

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Jan 4 11:33:43 EST 2019


pulkit added a comment.


  In https://phab.mercurial-scm.org/D5491#81291, @taapas1128 wrote:
  
  > no the date is updated in 2560. So below that it wont work
  
  
  I overlooked that, thanks for pointing.
  
  test-check-code.t and test-check-commit.t says hi!
  
  Also, the test output is flaky since dateutil.makedate() returns time.time() which always changes, this also leads to hash being changed in test output. You should glob time and hash I think.
  test-amend.t has two cases namely obsstore-on and obsstore-off. Output of both should be updated. You can do `#if obsstore-on else endif` kind of thing which is done in rest of the test.
  
  Also, please run all the tests.

INLINE COMMENTS

> cmdutil.py:2445
>          user = opts.get('user') or old.user()
>          date = opts.get('date') or old.date()
>  

Let's move the date changing logic here, it will be cleaner.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5491

To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list