D5489: histedit: add warning message on editing tagged commits (issue4017)

[mharbison72 (Matt Harbison)]

mharbison72 added inline comments.

INLINE COMMENTS

> navaneeth.suresh wrote in histedit.py:1707
> Otherwise, the user won't be able to see the warning as the editor opens for histedit.

Oh, OK.  Does it make sense to make this an interactive prompt to continue/bail instead, to ensure this isn't missed?  (Don't feel obligated- I wasn't going to say anything because I couldn't think of any other commands that prompt like this.  And then I remembered that absorb does.)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5489

To: navaneeth.suresh, durin42, #hg-reviewers
Cc: mharbison72, mercurial-devel