D5494: histedit: add user input to warning message on editing tagged commits

[navaneeth.suresh (Navaneeth Suresh)]

navaneeth.suresh created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5494

AFFECTED FILES
  hgext/histedit.py

CHANGE DETAILS

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -184,7 +184,6 @@
 from __future__ import absolute_import
 
 import os
-import time
 
 from mercurial.i18n import _
 from mercurial import (
@@ -1127,9 +1126,10 @@
             if not hastags:
                 hastags = len(tags)
     if hastags:
-        ui.warn(_('warning: tags associated with the given changeset '
-        'will be lost after histedit \n'))
-        time.sleep(1)
+        if ui.promptchoice(_('warning: tags associated with the given'
+            ' changeset will be lost after histedit. \n'
+            'do you want to continue (yN)? $$ &Yes $$ &No'), default=1):
+            raise error.Abort(_('histedit cancelled\n'))
     # rebuild state
     if goal == goalcontinue:
         state.read()



To: navaneeth.suresh, durin42, #hg-reviewers
Cc: mercurial-devel