D5502: tests: correct version check in clientreactor test

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Sun Jan 6 15:28:40 EST 2019


durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Experimentally, `(3, 6, 3)` is less than `sys.version_info` on an actual
  Python 3.6.3 installation. Let's just check `< (3, 6, 4)` instead of
  `<= (3, 6, 3)` so we stop seeing this bogus failure.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5502

AFFECTED FILES
  tests/test-wireproto-clientreactor.py

CHANGE DETAILS

diff --git a/tests/test-wireproto-clientreactor.py b/tests/test-wireproto-clientreactor.py
--- a/tests/test-wireproto-clientreactor.py
+++ b/tests/test-wireproto-clientreactor.py
@@ -601,7 +601,7 @@
         self.assertEqual(meta[b'data'], response2)
 
 if __name__ == '__main__':
-    if (3, 6, 0) <= sys.version_info <= (3, 6, 3):
+    if (3, 6, 0) <= sys.version_info < (3, 6, 4):
         # Python 3.6.0 through 3.6.3 inclusive shipped with
         # https://bugs.python.org/issue31825 and we can't run these
         # tests on those specific versions of Python. Sigh.



To: durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list