D5491: amend: added config option to update time to current in hg amend(issue5828)

[pulkit (Pulkit Goyal)]

pulkit accepted this revision.
pulkit added a comment.


  Queueing this, many thanks!
  
  I have left some inline comments, can you follow-up on them?

INLINE COMMENTS

> cmdutil.py:2447
>  
> +        if ui.configbool('rewrite','update-timestamp'):
> +            if opts.get('date'):

This one can be simplified as `if ui.configbool(..) and not opts.get('date')`.

> cmdutil.py:2573
>              # This not what we expect from amend.
> -            return old.node()
> +            if (date == old.date() or
> +                (ui.configbool('rewrite','update-timestamp') and

IIUC, this one can be `if (date ==old.date() or not opts.get('date')):`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5491

To: taapas1128, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel