D5503: vfs: add support for repo names with `$` when using with env vars (issue5739)

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   def __init__(self, base, audit=True, cacheaudited=False, expandpath=False,
  >                realpath=False):
  > 
  > +        if '$' in base and os.path.isdir(base):
  >  +            # when there exists a repo '$foo' and an env var foo=bar, stop
  >  +            # expanding path. refer issue5739.
  >  +            expandpath = False
  
  This is logically incorrect. The problem is that we're doing variable
  expansion at too lower layer. `vfs(expand(user_specified_path))` makes
  some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs class
  can't know where the `base` comes from.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5503

To: navaneeth.suresh, #hg-reviewers
Cc: yuja, mercurial-devel