D5514: test: change test's diff generation to use mdiff for nicer output

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Jan 8 11:48:15 EST 2019


durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> run-tests.py:72
>  import xml.dom.minidom as minidom
> +from mercurial import mdiff, patch
>  

This will fail if Mercurial isn't already globally installed on the machine, as would be the case in at least some packaging circumstances when building from a source tarball.

Probably need a try/except, and _maybe_ a sanity check that mdiff's API matches what we expect?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5514

To: sangeet259, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list