D5514: test: change test's diff generation to use mdiff for nicer output

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Jan 9 15:47:26 EST 2019


durin42 added a comment.


  In https://phab.mercurial-scm.org/D5514#81800, @sangeet259 wrote:
  
  > @durin42 So the `try/except` will fall back to `unified diff`?
  
  
  Correct.
  
  > Is there a way we can enforce this on system's that don't have mercurial installed globally and not have to fall back on the earlier practice.
  
  I think we don't have any choice: if hg isn't installed, we have to fall back to the old codepath, since we won't know if mdiff is present.
  
  > Also, I didn't get your comment on checking the API of `mdiff` :/
  
  Well, what if we iterate on the API of mdiff.new_diff? then again, if the point of it is to have the same API as difflib.unified_diff, probably don't need to worry (and so we only have to fall back to difflib if mdiff isn't available or is too old).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5514

To: sangeet259, #hg-reviewers, durin42
Cc: pulkit, durin42, mercurial-devel


More information about the Mercurial-devel mailing list