D5540: histedit: fix --continue and --abort when curses is enabled

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Jan 9 18:07:59 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> histedit.py:1605-1606
> +    # operations.
> +    if ui.interface('histedit') == 'curses' and not (
> +            opts.get( b'continue', False) or opts.get( b'abort', False)):
>          return _chistedit(ui, repo, *freeargs, **opts)

Maybe use `... and _getgoal(opts) == goalnew` instead? In addition to being simpler, that seems like it would also correctly handle the `--edit-plan` option (which I didn't even know existed until just now).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5540

To: durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list