D5519: simplestorerepo: minimal changes required to get this mostly working again

[indygreg (Gregory Szorc)]

indygreg added a comment.


  In https://phab.mercurial-scm.org/D5519#81903, @durin42 wrote:
  
  > In https://phab.mercurial-scm.org/D5519#81899, @indygreg wrote:
  >
  > > The original purpose of the simple store repo was to flush out problems with storage abstraction by building an alternate storage backend. Now that we have storage interface unit tests and the SQLite storage backend, there is definitely less of a need for the simple store backend and we could probably consider deleting it.
  >
  >
  > I wonder if it's worth keeping the simpler simplestore code as an example. Probably not?
  
  
  With the SQLite store being a thing, probably not worth keeping even as an example. That being said, if it works and isn't hard to maintain, then why not keep it? The problem is it is difficult to maintain. You need to teach various tests about the existing of different backends because test output varies. Search for `simplestore` in the tests directory to see all the conditionals. Given the cost of maintaining support, I don't think it can justify its existence.
  
  That being said, I'll probably regret this decision someday. Meh.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5519

To: durin42, indygreg, #hg-reviewers
Cc: mercurial-devel