Auto-formatting with yapf (was: Re: Auto-formatting code with black - object now if you have a strong opinion)

[Matt Harbison]

On Wed, 09 Jan 2019 15:30:19 -0500, Augie Fackler <raf at durin42.com> wrote:

>
>
>> On Dec 6, 2018, at 23:21, Matt Harbison <mharbison72 at gmail.com> wrote:
>>
>> On Wed, 05 Dec 2018 08:23:17 -0500, Yuya Nishihara <yuya at tcha.org>  
>> wrote:
>>
>>> On Tue, 4 Dec 2018 10:06:24 -0500, Augie Fackler wrote:
>>>>
>>>> So, options to move forward:
>>>> 1) blacken everything (controversial for good reasons)
>>>> 2) try black only on a subset
>>>> 3) explore yapf
>>>> 4) Give up and keep manually formatting files (I'd rather not do  
>>>> this, but I understand if it's where we end up)
>>>
>>> My vote: 3 > 4 > 2 > 1
>>>
>>> I'm not super enthusiastic about 100%-machine-forced formatting. I like
>>> consistency level provided by e.g. astyle command. clang-format is  
>>> pretty
>>> good IMHO, but the black seems to sacrifice the code readability.
>>
>> +1.
>>
>> That said, I got used to longnamesthataresmooshedtogether, so I can  
>> probably adjust to anything after awhile.
>
> I think I'd still prefer black overall (yapf is less opinionated and  
> requires me to think more), but here's a yapf RFC:  
> https://phab.mercurial-scm.org/D5539
>
> This would at least help _most_ cases of line-too-long, which I think  
> would be good. What do people think?

I think there's less that I dislike with yapf, but I'm not adamant about  
it.

Since I've never used auto formatting, I'm assuming the general procedure  
is to:

   1) code something the approximates the style
   2) run fix
   3) submit

If that's true, what's there to think about?