D5507: narrow: drop now-unnecessary reassignment of repo attributes
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jan 10 16:51:15 EST 2019
martinvonz updated this revision to Diff 13147.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5507?vs=13056&id=13147
REVISION DETAIL
https://phab.mercurial-scm.org/D5507
AFFECTED FILES
mercurial/localrepo.py
CHANGE DETAILS
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1254,12 +1254,6 @@
narrowspec.save(self, newincludes, newexcludes)
narrowspec.copytoworkingcopy(self)
self.invalidate(clearfilecache=True)
- # So the next access won't be considered a conflict
- # TODO: It seems like there should be a way of doing this that
- # doesn't involve replacing these attributes.
- self.narrowpats = newincludes, newexcludes
- self._narrowmatch = narrowspec.match(self.root, include=newincludes,
- exclude=newexcludes)
def __getitem__(self, changeid):
if changeid is None:
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list