D5490: commit: remove ignore whitespace option on --interactive (issue6042)
navaneeth.suresh (Navaneeth Suresh)
phabricator at mercurial-scm.org
Fri Jan 11 10:13:39 EST 2019
navaneeth.suresh added a comment.
> Sorry for late, but doesn't it break `hg record --ignore-all-space`, etc.?
Yes. Exactly! Thanks for pointing that out.
> It was intentionally added by https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f (with no tests.)
Do you want me to add tests for that? If yes, please mention the things I need to take care of on
writing those tests.
I've updated the revision and things are working fine. There is still `whitespace=True` existing
on calling `patch.difffeatureopts()` in `fastannotate`, `diffutil.diffallopts()`,
`webutil.difffeatureopts()` and ``cmdutil._performrevert()`. Is there anything
to be done on that?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5490
To: navaneeth.suresh, #hg-reviewers
Cc: yuja, durin42, pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list