D5490: commit: remove ignore whitespace option on --interactive (issue6042)

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   > It was intentionally added by https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f (with no tests.)
  >   
  >   Do you want me to add tests for that?  If yes, please mention the things I need to take care of on
  >    writing those tests.
  
  I think you can reuse the test you've written for `commit -i`.
  
  >   I've updated the revision and things are working fine. There is still `whitespace=True` existing
  >   on calling `patch.difffeatureopts()` in `fastannotate`, `diffutil.diffallopts()`,
  >   `webutil.difffeatureopts()` and ``cmdutil._performrevert()`. Is there anything
  >   to be done on that?
  
  Good questionn. Maybe we can't simply fix the issue6042 by turning off the
  whitespace options?
  
  `_performrevert()` would be in the same boat, but it was explicitly flagged on
  at https://phab.mercurial-scm.org/rHGf37a69ec3f4717fdb4f00699ca06c225f106696c. This implies that the `diff.ignorews` option would be used
  in practice to exclude whitespace changes while interactive commit/revert.
  So disabling any whitespace options would break someone's workflow.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5490

To: navaneeth.suresh, #hg-reviewers
Cc: yuja, durin42, pulkit, mercurial-devel