D5550: rust-cpython: bindings for MissingAncestors

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Mon Jan 14 20:57:45 EST 2019


gracinet marked 2 inline comments as done.
gracinet added inline comments.

INLINE COMMENTS

> gracinet wrote in ancestors.rs:170
> Thanks for the detailed answer.
> 
> Then the problem, in case of iterators coming directly from Python, is that they don't currently implement `size_hint()`, so there's an improvement to be done at this level (many Pythoin iterators do have a `__length_hint()` method, so it shouldn't be a problem to reuse it)
> 
> I have currently some suspicions that the conversions between Rust and Python are the bottleneck in some important cases, so I'll have to measure this things anyway. I won't touch that immediately, but I'll get back to it with real soon.

Got this one in the wrong direction (sorry about that!) : in this case, this is a conversion from Rust, so we de have proper `size_hint()`
Still, I'll keep in mind the question for the other direction (in which we are using `collect()` already.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5550

To: gracinet, #hg-reviewers
Cc: yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list