D5598: basepack: avoid 'rbe' mode in Python 3

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Jan 16 12:21:11 EST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc891a11ffe27: basepack: avoid 'rbe' mode in Python 3 (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D5598?vs=13258&id=13279

REVISION DETAIL
  https://phab.mercurial-scm.org/D5598

AFFECTED FILES
  hgext/remotefilelog/basepack.py

CHANGE DETAILS

diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py
--- a/hgext/remotefilelog/basepack.py
+++ b/hgext/remotefilelog/basepack.py
@@ -52,9 +52,10 @@
 # loaded the pack list.
 REFRESHRATE = 0.1
 
-if pycompat.isposix:
+if pycompat.isposix and not pycompat.ispy3:
     # With glibc 2.7+ the 'e' flag uses O_CLOEXEC when opening.
     # The 'e' flag will be ignored on older versions of glibc.
+    # Python 3 can't handle the 'e' flag.
     PACKOPENMODE = 'rbe'
 else:
     PACKOPENMODE = 'rb'



To: durin42, #hg-reviewers, pulkit
Cc: mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list