D5587: watchman: detect nested mercurial repositories and abort

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Jan 16 14:44:46 EST 2019


indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> __init__.py:766-768
> +    for f in os.listdir(repo.root):
> +        if os.path.isdir(os.path.join(repo.root, f, '.hg')):
> +            return True

Nit: we should be using `repo.vfs.listdir()` here, as all I/O should be abstracted via VFS layer. But I think this is fine (we make this violation in many other places).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5587

To: lothiraldan, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list