[PATCH 3 of 3 STABLE] rust: add comment about lack of wdirrev handling

Yuya Nishihara yuya at tcha.org
Mon Jan 21 17:42:13 EST 2019


On Mon, 21 Jan 2019 17:00:38 +0100, Georges Racinet wrote:
> Le 20 janvier 2019 04:11:11 GMT+01:00, Yuya Nishihara <yuya at tcha.org> a écrit :
> ># HG changeset patch
> ># User Yuya Nishihara <yuya at tcha.org>
> ># Date 1547953056 -32400
> >#      Sun Jan 20 11:57:36 2019 +0900
> ># Branch stable
> ># Node ID 13c23396c7fe1633a2336b29e3a32b9b76274f28
> ># Parent  66102f6fa10aa533a658532b198cd6879a538406
> >rust: add comment about lack of wdirrev handling
> >
> >If hg is compiled with rust support, 'only(wdir())' crashed as
> >"rustext.GraphError: ('ParentOutOfRange', 2147483647)", which should
> >instead
> >say "abort: working directory revision cannot be specified."
> 
> I can fix that easily if you like, and it seems possible to me that rust-core could get awareness of wdirrev and that rust-cpython would raise the proper exception.
> 
> If that's too much for the stable branch, a simple try/except as is already done in the C case would be enough.

Thanks. I think it's better to translate wdirrev to error in Rust part.
try-catch won't be viable solution as Rust core gets more laziness and
object APIs.


More information about the Mercurial-devel mailing list