[Bug 6059] New: `hg files` regression on c2aea007

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=6059

            Bug ID: 6059
           Summary: `hg files` regression on c2aea007
           Product: Mercurial
           Version: 4.9rc0
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla at mercurial-scm.org
          Reporter: lothiraldan at gmail.com
                CC: mercurial-devel at mercurial-scm.org

Our performance test suite identified an `hg files`  regression on c2aea007

Here are the numbers:

Benchmarks that have got worse:

       before           after         ratio
     [197f092b]       [593718ff]
+         739±4ms          871±5ms     1.18 
time_files('mozilla-central-2018-08-01')
+         748±7ms          872±5ms     1.17 
time_files('mozilla-central-2018-08-01-sparse-revlog')
+         353±2ms          399±2ms     1.13  time_files('netbeans-2018-08-01')
+         352±2ms          397±2ms     1.13 
time_files('netbeans-2018-08-01-sparse-revlog')

I took a quick look at the commit but I don't know if that's an overhead from
the `_isbuffered` call, the additional `ifs` or another part of the change.

This regression is likely to impact others commands but with much less impact
than `hg files`.

-- 
You are receiving this mail because:
You are on the CC list for the bug.