[PATCH 3 of 3 STABLE] rust-cpython: raising error.WdirUnsupported
Josef 'Jeff' Sipek
jeffpc at josefsipek.net
Thu Jan 24 16:31:07 EST 2019
On Thu, Jan 24, 2019 at 15:41:56 -0500, Georges Racinet wrote:
> On 1/24/19 11:11 AM, Josef 'Jeff' Sipek wrote:
>
> > On Wed, Jan 23, 2019 at 23:23:53 -0500, Georges Racinet wrote:
> > ...
> >> diff -r a35cfd592a90 -r 47d5458a4c32 tests/test-rust-ancestor.py
> >> --- a/tests/test-rust-ancestor.py Wed Jan 23 07:47:04 2019 -0500
> >> +++ b/tests/test-rust-ancestor.py Wed Jan 23 07:49:36 2019 -0500
> >> @@ -1,6 +1,10 @@
> >> from __future__ import absolute_import
> >> import sys
> >> import unittest
> >> +from mercurial import (
> >> + error,
> >> + node,
> >> + )
> > Is there supposed to be whitespace before the ) ? I'm not all that familiar
> > with the python coding style.
>
> I'm not sure about that, but the coding style [1] doesn't seem to say
> much about that case, and, since it's cited as a lose reference, pep8
> accepts both.
>
> The indentation you're seeing is just what my editor does by default. I
> didn't do anything else than making test-check-* happy
Fair enough. Sorry for the noise. :)
For the little it is worth, I didn't see anything wrong with the rest of the
series.
Jeff.
--
Reality is merely an illusion, albeit a very persistent one.
- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20190124/b6c732b4/attachment.sig>
More information about the Mercurial-devel
mailing list