D5635: branchmap: make branchcache responsible for reading

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Jan 25 15:35:09 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> perf.py:2326
>  
> -    branchcacheread = safeattrsetter(branchmap, b'read')
> +    branchcacheread = safeattrsetter(branchmap.branchcache, b'fromfile')
>      branchcachewrite = safeattrsetter(branchmap.branchcache, b'write')

As I was recently reminded by Yuya, the perf commands are supposed to be compatible with older versions of hg too, and this doesn't seem to be compatible with the `branchmap.read()` version.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5635

To: mjpieters, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list