D5635: branchmap: make branchcache responsible for reading

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Sat Jan 26 09:42:21 EST 2019


martinvonz added inline comments.

INLINE COMMENTS

> mjpieters wrote in perf.py:2326
> Why is that? @yuja, can you elaborate?
> 
> This is version-controlled code that changes in lock-step with the branchmap module, adding backwards compatibility tests here would add a costly maintenance burden. If you have an older revision of the branchmap module, you also have an older revision of the perf code.

I'm pretty sure the idea is that you should be able to enable the latest perf extension and run different versions of hg (perhaps versions that you had already built) against it to compare performance.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5635

To: mjpieters, #hg-reviewers
Cc: yuja, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list