D5635: branchmap: make branchcache responsible for reading

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Jan 26 21:52:44 EST 2019


yuja added a comment.


  >> Why is that? @yuja, can you elaborate?
  >  > 
  >  > This is version-controlled code that changes in lock-step with the branchmap module, adding backwards compatibility tests here would add a costly maintenance burden. If you have an older revision of the branchmap module, you also have an older revision of the perf code.
  > 
  > I'm pretty sure the idea is that you should be able to enable the latest perf extension and run different versions of hg (perhaps versions that you had already built) against it to compare performance.
  
  Something like that IIRC. A perf function itself can be improved in a way
  that the resulting number isn't comparable with the one of older perf codes.
  
  It's documented in the header. https://phab.mercurial-scm.org/rHG4533f5b47949a4d0544bda9bc65c34622c560928

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5635

To: mjpieters, #hg-reviewers
Cc: yuja, martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list