D5739: py3: use pycompat.bytestr() so that slicing does not result in ascii values

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Jan 30 07:21:56 EST 2019


yuja added a comment.


  >   command.append('l')
  >   for arg in args:
  > 
  > - command += "%d:%s" % (len(arg), arg) +            command += pycompat.bytestr("%d:%s" % (len(arg), arg))
  
  It's okay, but I think the original code would mean to do `command.append(...)`.
  
  >   command.append('e')
  >   command = ''.join(command)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5739

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list